Updates BSK version and fixes a tester issue in iOS #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2023
graeme
approved these changes
Sep 12, 2023
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Sep 12, 2023
Task/Issue URL: https://app.asana.com/0/0/1205466155643247/f iOS PR: duckduckgo/iOS#2003 macOS PR: duckduckgo/macos-browser#1581 What kind of version bump will this require?: Patch ## Description Fixes tunnel startup options handling, and improves the options loading mechanism to make it unit testable. --- * Fixes startup options reset * Makes a correction to my previous commits * WIP * WIP * Adds unit tests for StartupOptions * Fixes some swiftlint warnings and improves the code
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Sep 12, 2023
Task/Issue URL: https://app.asana.com/0/0/1205465612515839/f BSK PR: duckduckgo/BrowserServicesKit#489 iOS PR: duckduckgo/iOS#2003 ## Description Fixes startup options reset, and improves the options loading logic so we can easily unit test it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network Protection: Connection Tester
Task/Issue URL: https://app.asana.com/0/0/1205465612515847/f
BSK PR: duckduckgo/BrowserServicesKit#489
macOS PR: duckduckgo/macos-browser#1581
Description
Fixes startup options reset, and improves the options loading logic so we can easily unit test it.
Testing
Test the connection tester
Test the connection
Internal references:
Software Engineering Expectations
Technical Design Template